Skip to content

Draft: Make <shift>KP_n Accelerators Work

programmer_ceds requested to merge programmer_ceds/gimp:Delete_KP_Shift_Key_Accelerators into master

Closes #2796

The view-zoom actions have KP_1 to KP_5 as alternatives to the 1 to 5 numeric keys - no problem with this.

However, <Shift>1 to <Shift>5 have <Shift>KP_1 to <Shift>KP_5 as alternatives. I haven't seen a numeric keypad that has "shiftable" keys. Moreover, on my system if I take the keyname KP_5 (for example), convert it to a keyval, then convert the keyval to a keycode and finally use gdk_keymap_lookup_key() supplied with a GdkKeymapKey parameter with the level parameter set to 1 (for shift) it returns KP_5. (If I repeat this with the key 'a' I end up with 'A' as expected, so the conversion code is working). If GTK followed this procedure for the view-zoom shortcuts it would effectively mean that KP_5 was assigned to two different actions - which zoom factor would win?

Edited by Bruno

Merge request reports